I’d always suggest sorting by element type first, and then by colour.
But I guess that method doesn’t translate as easily to colouring books.
I’d also advocate storing your Lego bricks somewhere safely away from UV light which might bleach the bricks. Not at the end of some rainbow like Nathan advises.