Depends on your personal tastes. For more casual and warm-weather trousers (chinos, especially) I tend to go short to no-break, since I prefer to usually go sockless.
On more conservative and cold-weather stuff, I go with a medium break, especially if it’ll be used over a boot (and I’ll likely do a cuff as well).
Worth giving a read at Put This On and Brooks Brothers.